Merge lp:~florian-rathgeber/fluidity/with-zoltan-no-configure-fix into lp:fluidity

Proposed by Florian Rathgeber
Status: Merged
Approved by: Florian Rathgeber
Approved revision: 3986
Merged at revision: 3995
Proposed branch: lp:~florian-rathgeber/fluidity/with-zoltan-no-configure-fix
Merge into: lp:fluidity
Diff against target: 70 lines (+14/-14)
2 files modified
configure (+6/-6)
configure.in (+8/-8)
To merge this branch: bzr merge lp:~florian-rathgeber/fluidity/with-zoltan-no-configure-fix
Reviewer Review Type Date Requested Status
Jon Hill Approve
David Ham Pending
Review via email: mp+105688@code.launchpad.net

This proposal supersedes a proposal from 2012-05-14.

Description of the change

Fix the "with_zoltan=no" configure option, which was without effect.

To post a comment you must log in.
Revision history for this message
Jon Hill (jon-hill) wrote :

When I added this I made the decision that --with-zoltan=no was not the same as --with-sam, however, that was a stupid decision as --with-zoltan=no effectively means --with-sam. Thanks for fixing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2012-03-28 16:32:39 +0000
3+++ configure 2012-05-14 16:59:20 +0000
4@@ -11713,12 +11713,12 @@
5 fi
6
7 if test "$enable_sam" = "yes"; then
8+ HAVE_ZOLTAN=no
9+else
10+ if test "$with_zoltan" = no; then
11 HAVE_ZOLTAN=no
12-else
13- if test "$with_zoltan" = no; then
14- HAVE_ZOLTAN=no
15- echo "Warning: zoltan disabled, using libsam instead"
16- fi
17+ echo "Warning: zoltan disabled, using libsam instead"
18+ else
19 HAVE_ZOLTAN=yes
20 zoltan=yes
21
22@@ -11836,11 +11836,11 @@
23
24 echo $LIBS
25
26+ fi
27 fi
28
29
30
31-
32 HAVE_ADJOINT=no
33 CAN_USE_ADJOINT=yes
34 WANTS_ADJOINT=yes
35
36=== modified file 'configure.in'
37--- configure.in 2012-02-14 17:28:17 +0000
38+++ configure.in 2012-05-14 16:59:20 +0000
39@@ -801,23 +801,23 @@
40 ACX_ParMetis([AC_MSG_NOTICE(["ParMetis found"])], [AC_MSG_WARN(["ParMetis not found"])])
41
42 AC_ARG_ENABLE(sam,
43- [AC_HELP_STRING([--enable-sam],
44- [use sam rather than zoltan for adaptive load rebalancing])])
45+ [AC_HELP_STRING([--enable-sam],
46+ [use sam rather than zoltan for adaptive load rebalancing])])
47 if test "$enable_sam" = "yes"; then
48+ HAVE_ZOLTAN=no
49+else
50+ if test "$with_zoltan" = no; then
51 HAVE_ZOLTAN=no
52-else
53- if test "$with_zoltan" = no; then
54- HAVE_ZOLTAN=no
55- echo "Warning: zoltan disabled, using libsam instead"
56- fi
57+ echo "Warning: zoltan disabled, using libsam instead"
58+ else
59 HAVE_ZOLTAN=yes
60 zoltan=yes
61 ACX_zoltan([AC_MSG_NOTICE(["Zoltan found"])], [AC_MSG_WARN(["Zoltan not found"])])
62+ fi
63 fi
64 AC_SUBST(HAVE_ZOLTAN)
65
66
67-
68 HAVE_ADJOINT=no
69 CAN_USE_ADJOINT=yes
70 WANTS_ADJOINT=yes