> Nice work, thanks :)
>
> See below a few comments about code style and some other things.
>
> We also need documentations for the public methods to get this merged, which
> will be used to generate the api docs (see other files (e.g. the widgets are
> well documented) if you are looking for examples).
=== modified file 'src/Contract.vala'
--- src/Contract.vala 2013-05-20 04:55:11 +0000
+++ src/Contract.vala 2015-09-13 00:54:10 +0000
@@ -72,6 +77,12 @@
} catch (Error err) { warning ("Contract '%s' does not provide an icon (%s)", id, err.message);
}
+
+ try {
+ max_file_size = keyfile.get_max_file_size ();
+ } catch (Error err) {
+ warning ("Contract '%s' does not provide a max file size (%s)", id, err.message);
Should I change the warning outputs of all optional contract fields to debug outputs?
> Nice work, thanks :)
>
> See below a few comments about code style and some other things.
>
> We also need documentations for the public methods to get this merged, which
> will be used to generate the api docs (see other files (e.g. the widgets are
> well documented) if you are looking for examples).
=== modified file 'src/Contract.vala'
warning ("Contract '%s' does not provide an icon (%s)", id, err.message); get_max_ file_size ();
--- src/Contract.vala 2013-05-20 04:55:11 +0000
+++ src/Contract.vala 2015-09-13 00:54:10 +0000
@@ -72,6 +77,12 @@
} catch (Error err) {
}
+
+ try {
+ max_file_size = keyfile.
+ } catch (Error err) {
+ warning ("Contract '%s' does not provide a max file size (%s)", id, err.message);
Should I change the warning outputs of all optional contract fields to debug outputs?