Code review comment for lp:~flimm/mct/packaging

Revision history for this message
Isaiah Heyer (freshapplepy) wrote :

On Thu, 2009-03-05 at 16:30 +0000, David D Lowe wrote:
> David D Lowe has proposed merging lp:~flimm/mct/packaging into lp:mct.
>
> Requested reviews:
> Isaiah Heyer (freshapplepy)
>
> Packaged Metacity Themer for Ubuntu. I added directory named debian and a file called setup.py. Now you can package Metacity Themer by running:
> dpkg-buildpackage
> or
> dpkg-buildpackage -S # if you want just the source package
> You can upload source packages to launchpad PPAs.
> I had to change some things in mct's code: I moved share/metacity_themer/lib/metacity_themer to the root of the branch, as it's a python package. It will be installed to /usr/lib/python2.5/site-packages and be in sys.path.
> I also made the program to expect data files to be in /usr/share/metacity_theme/ , but only if it can't find them in its local directory, as would be expected if you're running it from source.
> I recommend you merge this into the trunk, so that you can keep the changelog up to date (dch -e) and so on.
>

I already had a debian directory, I just hadn't added it to the branch
yet. I didn't really want the metacity_themer python package in the
python package directory because nothing is going to use it except the
program.

Since you moved everything around does it still run?Can it still find
all the glade files and translation stuff and images?

« Back to merge proposal