Code LGTM :)
You now need to add some headers to make Codecheck happy, then this can go in.
widelands/src/ui_fsmenu/loadgame.cc:117: This file uses unique_ptr but does not include <memory>.
widelands/src/wui/load_or_save_game.cc:171: This file uses unique_ptr but does not include <memory>.
widelands/src/wui/load_or_save_game.h:46: This file uses unique_ptr but does not include <memory>.
The reason for this rule is that some compilers will barf if unique_ptr is used without this header.
Documentation on how to run codecheck yourself: https://wl.widelands.org/wiki/RegressionTests/
« Back to merge proposal
Code LGTM :)
You now need to add some headers to make Codecheck happy, then this can go in.
widelands/ src/ui_ fsmenu/ loadgame. cc:117: This file uses unique_ptr but does not include <memory>.
widelands/ src/wui/ load_or_ save_game. cc:171: This file uses unique_ptr but does not include <memory>.
widelands/ src/wui/ load_or_ save_game. h:46: This file uses unique_ptr but does not include <memory>.
The reason for this rule is that some compilers will barf if unique_ptr is used without this header.
Documentation on how to run codecheck yourself: https:/ /wl.widelands. org/wiki/ RegressionTests /