> I have added you to widelands-dev, so you we can work together on branches in
Thanks!
> the future. Just don't push directly to trunk :)
I keep that in mind!
> I think we can have a std::unique_ptr here for all the variables that you
> touched. It is clear who owns it, so we don't need shared_ptr, and raw
> pointers are something we want to get rid of.
Sounds good to me. I can try to change those to unique ones.
> The only raw pointers that are OK are for UI::Panel and its subclasses,
> because the pointers are managed well within UI::Panel and it would be a huge
> job to refactor that.
Good to know!
> I have added you to widelands-dev, so you we can work together on branches in
Thanks!
> the future. Just don't push directly to trunk :)
I keep that in mind!
> I think we can have a std::unique_ptr here for all the variables that you
> touched. It is clear who owns it, so we don't need shared_ptr, and raw
> pointers are something we want to get rid of.
Sounds good to me. I can try to change those to unique ones.
> The only raw pointers that are OK are for UI::Panel and its subclasses,
> because the pointers are managed well within UI::Panel and it would be a huge
> job to refactor that.
Good to know!