Code review comment for lp:~flegu/widelands/fix_some_memory_leaks

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Compiled and tested all Dialogs I could think for, ok

testing with malloc debug settings:
#! /bin/bash
export MallocGuardEdges=1
export MallocScribble=1
export MallocStackLogging=1
export MallocCheckHeapStart=0
export MallocCheckHeapEach=1
export MallocCheckHeapSleep=600

this gives an segfault on closing, but its the same on trunk.

plese check inline comment. Otherwise code LGTM.

Gun: get me mereg a private bracnh wit bunnybot and all,
or must his me moved to wideldans namespace, first.

review: Approve (compile, test, review)

« Back to merge proposal