Code review comment for lp:~flameeyes/gearmand/gentoo-fixes

Il giorno lun, 05/07/2010 alle 16.44 +0000, Monty Taylor ha scritto:
>
> Yeah - so I see what you're doing, but I'm going to need to poke at
> this some on the other platforms. I _really_ don't like trusting
> things like pg_config.

Not sure on Ubuntu but Gentoo tries to keep these scripts valid because
they _are_ the only way upstream has to signal them..
>
> Also- why did you add and include of the pg_config.h include? That's
> going to have values from their run of configure which we do not care
> about?

That's how most other projects get the correct build parameters, without
this it fails here ... I sincerely forgot the error message right now.

--
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/