Launchpad itself

Code review comment for lp:~flacoste/launchpad/bug-801233

Revision history for this message

Brad Crittenden (bac) wrote on 2011-07-11:

Hi Francis,

This is a really good follow up branch to the changes I made. Thanks for making the processor traversal by name.

I only found a few things to note:

* As we discussed on IRC the docstring for getBuildQueueSizes make the wadl generator unhappy.

* In lib/lp/services/webservice/json.py you should add StrJSONSerializer to __all__.

* In lib/lp/testing/factory.py, s/same name than the family./same name as the family./

* Some of the lint is real, including new code with super long lines such as in test_default_collection.

* in ProcessorSet getAll and getByName why don't you use the storeOf(self)?

review: Approve (code)