Merge lp:~fincha/openshot/openshot-andy into lp:openshot/1.4

[Andy Finch]

[lp:~fincha/openshot/openshot-andy]

19. By Andy Finch on 2008-11-23

Fixed a bug that affected refreshing of the detail view. Also tidied up the file propeties dialog so it is audio/video specific.

[Jonathan Thomas (jonoomph)]

I was able to successfully merge the branch!

review: Approve

[Andy Finch (fincha)]

That's good. I see I will need to create a new branch as the existing one
has gone, that should make things cleaner.

I was starting to take a look at adding folders to the tree last night. I
guess I'm not sure what the intention is behind them - are they for
'grouping' sets of files together in the tree, i.e. add a folder called
'audio files' and add all the audio files in there so they sit in a
hierarchy in the tree. Or do you mean adding in a whole folder from the file
system including any relevant files?

Cheers,
Andy.

On Tue, Nov 25, 2008 at 7:26 AM, Jonathan Thomas
<email address hidden>wrote:

> Vote: Approve
> I was able to successfully merge the branch!
> --
> https://code.launchpad.net/~fincha/openshot/openshot-andy/+merge/1858<https://code.launchpad.net/%7Efincha/openshot/openshot-andy/+merge/1858>
> You are subscribed to branch lp:~fincha/openshot/openshot-andy.
>

[Jonathan Thomas (jonoomph)]

The main reasoning behind the folders is simply to group files together, so
it's easier to locate the file you need, such as the "audio files" example
you mentioned. I don't think it would be terribly useful to allow a user to
drop a file-system folder into OpenShot, since you can already select all
files in a folder, and drop them in.

So... I would say that our focus on the tree should be to easily group,
arrange, and find the files you are looking for. So... maybe we only need a
single level of nesting in the tree... to keep things simple.

Also, once you get the latest code, be sure that all of your changes are
working as designed. I did my best with the merge tools, but I could have
easily lost a method here and there.

Oh yeah, one more thought. On the thumbnail view, do you think we should
show the "label" instead of the file name?

I'm working as fast as I can on the timeline... and related features. I'm
excited to get this to a point where we can start editing some videos!

Thanks!
-Jonathan

On Tue, Nov 25, 2008 at 2:21 AM, Andy Finch
<email address hidden>wrote:

> That's good. I see I will need to create a new branch as the existing one
> has gone, that should make things cleaner.
>
> I was starting to take a look at adding folders to the tree last night. I
> guess I'm not sure what the intention is behind them - are they for
> 'grouping' sets of files together in the tree, i.e. add a folder called
> 'audio files' and add all the audio files in there so they sit in a
> hierarchy in the tree. Or do you mean adding in a whole folder from the
> file
> system including any relevant files?
>
> Cheers,
> Andy.
>
>
>
> On Tue, Nov 25, 2008 at 7:26 AM, Jonathan Thomas
> <email address hidden>wrote:
>
> > Vote: Approve
> > I was able to successfully merge the branch!
> > --
> > https://code.launchpad.net/~fincha/openshot/openshot-andy/+merge/1858<https://code.launchpad.net/%7Efincha/openshot/openshot-andy/+merge/1858>
> <https://code.launchpad.net/%7Efincha/openshot/openshot-andy/+merge/1858>
> > You are subscribed to branch lp:~fincha/openshot/openshot-andy.
> >
>
> --
> https://code.launchpad.net/~fincha/openshot/openshot-andy/+merge/1858<https://code.launchpad.net/%7Efincha/openshot/openshot-andy/+merge/1858>
> You are subscribed to branch lp:openshot.
>