Merge lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609 into lp:ubuntu/utopic/dialer-app

Proposed by Filip Sohajek
Status: Rejected
Rejected by: Daniel Holbach
Proposed branch: lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609
Merge into: lp:ubuntu/utopic/dialer-app
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
src/qml/DialerPage/KeypadEntry.qml (+1/-1)
To merge this branch: bzr merge lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Needs Fixing
Review via email: mp+229565@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

It looks like the code was refactored in the meantime and this is not applicable anymore. Could I also suggest you use lp:dialer-app for this package? Thanks a lot for your work on this!

review: Needs Fixing
Revision history for this message
Filip Sohajek (filip-sohajek-deactivatedaccount) wrote :

Yes, and that refactoring fixed the bug.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks.

Unmerged revisions

52. By Filip Sohajek

src/qml/DialerPage/Dialer.qml: Added long phone numbers support (LP: #1351609)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-07-30 17:56:15 +0000
+++ debian/changelog 2014-08-05 07:54:18 +0000
@@ -1,3 +1,9 @@
1dialer-app (0.1+14.10.20140730-0ubuntu2) utopic; urgency=low
2
3 * src/qml/DialerPage/Dialer.qml: Added long phone numbers support (LP: #1351609)
4
5 -- Filip Sohajek <filip.sohajek@gmail.com> Tue, 05 Aug 2014 09:51:51 +0200
6
1dialer-app (0.1+14.10.20140730-0ubuntu1) utopic; urgency=low7dialer-app (0.1+14.10.20140730-0ubuntu1) utopic; urgency=low
28
3 [ Bill Filler ]9 [ Bill Filler ]
410
=== modified file 'src/qml/DialerPage/KeypadEntry.qml'
--- src/qml/DialerPage/KeypadEntry.qml 2014-07-16 20:43:36 +0000
+++ src/qml/DialerPage/KeypadEntry.qml 2014-08-05 07:54:18 +0000
@@ -46,7 +46,7 @@
46 font.weight: Font.Light46 font.weight: Font.Light
47 font.family: "Ubuntu"47 font.family: "Ubuntu"
48 color: "#AAAAAA"48 color: "#AAAAAA"
49 maximumLength: 2049 maximumLength: 30
50 focus: true50 focus: true
51 cursorVisible: true51 cursorVisible: true
52 clip: true52 clip: true

Subscribers

People subscribed via source and target branches

to all changes: