Merge lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609 into lp:ubuntu/utopic/dialer-app

Proposed by Filip Sohajek
Status: Rejected
Rejected by: Daniel Holbach
Proposed branch: lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609
Merge into: lp:ubuntu/utopic/dialer-app
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
src/qml/DialerPage/KeypadEntry.qml (+1/-1)
To merge this branch: bzr merge lp:~filip-sohajek-deactivatedaccount/ubuntu/utopic/dialer-app/fix-for-1361609
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Needs Fixing
Review via email: mp+229565@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

It looks like the code was refactored in the meantime and this is not applicable anymore. Could I also suggest you use lp:dialer-app for this package? Thanks a lot for your work on this!

review: Needs Fixing
Revision history for this message
Filip Sohajek (filip-sohajek-deactivatedaccount) wrote :

Yes, and that refactoring fixed the bug.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks.

Unmerged revisions

52. By Filip Sohajek

src/qml/DialerPage/Dialer.qml: Added long phone numbers support (LP: #1351609)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-07-30 17:56:15 +0000
3+++ debian/changelog 2014-08-05 07:54:18 +0000
4@@ -1,3 +1,9 @@
5+dialer-app (0.1+14.10.20140730-0ubuntu2) utopic; urgency=low
6+
7+ * src/qml/DialerPage/Dialer.qml: Added long phone numbers support (LP: #1351609)
8+
9+ -- Filip Sohajek <filip.sohajek@gmail.com> Tue, 05 Aug 2014 09:51:51 +0200
10+
11 dialer-app (0.1+14.10.20140730-0ubuntu1) utopic; urgency=low
12
13 [ Bill Filler ]
14
15=== modified file 'src/qml/DialerPage/KeypadEntry.qml'
16--- src/qml/DialerPage/KeypadEntry.qml 2014-07-16 20:43:36 +0000
17+++ src/qml/DialerPage/KeypadEntry.qml 2014-08-05 07:54:18 +0000
18@@ -46,7 +46,7 @@
19 font.weight: Font.Light
20 font.family: "Ubuntu"
21 color: "#AAAAAA"
22- maximumLength: 20
23+ maximumLength: 30
24 focus: true
25 cursorVisible: true
26 clip: true

Subscribers

People subscribed via source and target branches

to all changes: