Code review comment for lp:~fhscholl/4eturntracker/4eturntracker

Revision history for this message
Frank Scholl (fhscholl) wrote :

Thanks. Honestly, so am I. I would never have even remotely considered
trying any of the fancy decoration on the LineEdit if it wasn't for Qt. I'm
quickly falling in love with the whole Qt framework.

Of course you now realize that since the dice roller is a simple drop in UI
element, I'm going to start replacing other boxes with it. Namely I'll put
it in the power damage instead of the 3 fields with the drop down and the
power healing in place of the SpinBox. The only hesitation I have is the
option for DM override. I think there should be the option for the DM to
change the value before it is applied. I'm just not sure where to put it so
it doesn't look redundant or become more annoying than useful.
 On Oct 3, 2013 5:06 AM, "Paul McCullagh" <email address hidden> wrote:

> Hi Frank,
>
> Well done with this changes! I am impressed with the dice roller!
> --
>
> https://code.launchpad.net/~fhscholl/4eturntracker/4eturntracker/+merge/188763
> You are the owner of lp:~fhscholl/4eturntracker/4eturntracker.
>

« Back to merge proposal