Merge lp:~fginther/sudoku-app/fix-open-toolbar into lp:sudoku-app

Proposed by Francis Ginther
Status: Rejected
Rejected by: Alan Pope 🍺🐧🐱 πŸ¦„
Proposed branch: lp:~fginther/sudoku-app/fix-open-toolbar
Merge into: lp:sudoku-app
Diff against target: 22 lines (+11/-0) (has conflicts)
1 file modified
tests/autopilot/sudoku_app/emulators/ubuntusdk.py (+11/-0)
Text conflict in tests/autopilot/sudoku_app/emulators/ubuntusdk.py
To merge this branch: bzr merge lp:~fginther/sudoku-app/fix-open-toolbar
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+181388@code.launchpad.net

Commit message

This is a MP for testing jenkins, PLEASE DO NOT MERGE.

Description of the change

This is a MP for testing jenkins, PLEASE DO NOT MERGE.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

104. By Francis Ginther

Add animating wait_for to open_toolbar.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/sudoku_app/emulators/ubuntusdk.py'
--- tests/autopilot/sudoku_app/emulators/ubuntusdk.py 2013-08-20 15:40:09 +0000
+++ tests/autopilot/sudoku_app/emulators/ubuntusdk.py 2013-08-21 19:19:35 +0000
@@ -119,7 +119,18 @@
119119
120 def open_toolbar(self):120 def open_toolbar(self):
121 """Open the toolbar"""121 """Open the toolbar"""
122<<<<<<< TREE
122 panel = self.app.select_single("Toolbar")123 panel = self.app.select_single("Toolbar")
124=======
125 toolbar = self.get_toolbar()
126 toolbar.animating.wait_for(False)
127 if not toolbar.opened:
128 self._drag_to_open_toolbar()
129 toolbar.opened.wait_for(True)
130 toolbar.animating.wait_for(False)
131
132 def _drag_to_open_toolbar(self):
133>>>>>>> MERGE-SOURCE
123 qmlView = self.get_qml_view()134 qmlView = self.get_qml_view()
124135
125 lineX = int(qmlView.x + qmlView.width * 0.50)136 lineX = int(qmlView.x + qmlView.width * 0.50)

Subscribers

People subscribed via source and target branches