Code review comment for lp:~fginther/jenkins-launchpad-plugin/wait-for-node

Revision history for this message
Martin Mrazik (mrazik) wrote :

using PreemptiveBasicAuthHandler class from[1] instead of urllib2.HTTPBasicAuthHandler seems to fix the issue (well, then it fails on the json.load call but that seems to be straightforward).

What about adding PreemptiveBasicAuthHandler and renaming JSONJenkins to something else (JenkinsURLlib?) providing two different methods -- get_json_data (with the json.load as its right now) and get_data (returning raw data)?

[1]
http://pythonhosted.org/jenkinsapi/_modules/jenkinsapi/utils/urlopener.html

« Back to merge proposal