Merge lp:~fginther/fake-juju/fix-makefile-python-path into lp:~landscape/fake-juju/trunk-old

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 51
Merged at revision: 56
Proposed branch: lp:~fginther/fake-juju/fix-makefile-python-path
Merge into: lp:~landscape/fake-juju/trunk-old
Diff against target: 38 lines (+8/-4)
2 files modified
Makefile (+6/-2)
python/setup.py (+2/-2)
To merge this branch: bzr merge lp:~fginther/fake-juju/fix-makefile-python-path
Reviewer Review Type Date Requested Status
Eric Snow (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+311303@code.launchpad.net

Commit message

Update Makefile and setup.py to install 'PyYAML' and with with yakkety python-setuptools.

Description of the change

Update Makefile and setup.py to install 'PyYAML' and with with yakkety python-setuptools.

Testing instructions:
1) Make yakkety, xenial, trusty and precise packages with sbuild

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 51
Branch: lp:~fginther/fake-juju/fix-makefile-python-path
Jenkins: https://ci.lscape.net/job/latch-test-xenial/974/

review: Approve (test results)
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2016-11-18 12:49:28 +0000
+++ Makefile 2016-11-18 19:38:36 +0000
@@ -129,7 +129,11 @@
129ifndef PYTHON_INSTALLDIR129ifndef PYTHON_INSTALLDIR
130PYTHON_INSTALLDIR = $(DESTDIR)/usr/lib/python2.7/dist-packages130PYTHON_INSTALLDIR = $(DESTDIR)/usr/lib/python2.7/dist-packages
131endif131endif
132PYTHON_INSTALL_OPTION = --install-lib $(PYTHON_INSTALLDIR)132ifndef PYTHON_SCRIPTDIR
133PYTHON_SCRIPTDIR = $(DESTDIR)/usr/local/bin
134endif
135MODULEDIR = $(DESTDIR)/usr/local/bin
136PYTHON_INSTALL_OPTION = --install-lib $(PYTHON_INSTALLDIR) --install-scripts $(PYTHON_SCRIPTDIR)
133137
134PYTHON_LIB_ROOT = $(shell pwd)/python138PYTHON_LIB_ROOT = $(shell pwd)/python
135# TODO: read from python/fakejuju/__init__.py139# TODO: read from python/fakejuju/__init__.py
@@ -149,7 +153,7 @@
149 if [ ! "$(SKIP_PYTHON_LIB)" ]; then \153 if [ ! "$(SKIP_PYTHON_LIB)" ]; then \
150 mkdir -p $(PYTHON_INSTALLDIR); \154 mkdir -p $(PYTHON_INSTALLDIR); \
151 cd python; \155 cd python; \
152 $(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \156 PYTHONPATH=$(PYTHON_INSTALLDIR):$$PYTHONPATH $(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \
153 fi157 fi
154158
155.PHONY: py-install-dev159.PHONY: py-install-dev
156160
=== modified file 'python/setup.py'
--- python/setup.py 2016-10-24 20:21:11 +0000
+++ python/setup.py 2016-11-18 19:38:36 +0000
@@ -45,8 +45,8 @@
45DEPS = ['fixtures',45DEPS = ['fixtures',
46 'testtools',46 'testtools',
47 'txjuju',47 'txjuju',
48 'twisted',48 'Twisted',
49 'yaml',49 'PyYAML',
50 ]50 ]
5151
5252

Subscribers

People subscribed via source and target branches