Code review comment for lp:~fginther/cupstream2distro-config/mbs-rebuild-support

Revision history for this message
Francis Ginther (fginther) wrote :

> Can we strip whitespace from rebuild_job in here (in case somebody specifies
> rebuild like "job1, job2")?:
>
> 46 + for rebuild_job in data.split(','):
> 47 + rebuild_list.append('-'.join([rebuild_job,
> 'rebuild']))
> 48 + ctx['rebuild'] = ','.join(rebuild_list)

Done (revision 298)

> The following (needs info only):
> 795 + rebuild: grail-raring
>
> Would it be too hard to specify only "grail" and the update tool would check
> the current stack and find out there is a "grail-raring" base job? If it would
> be too hard maybe we can create a check in the validator for it? This feels a
> bit error prone/not obvious to me.

I originally thought this was going to be hard, so I left it out. But after taking a second look, I found a way to make it work (revision 300). Now, the user just needs to specify the project name to rebuild if it exists in the same stack. If it's not found, it's treated as an actual rebuild job name.

> Other than that looks good.

« Back to merge proposal