Merge lp:~fginther/core-image-publisher/hardcoded-edge-rolling into lp:core-image-publisher

Proposed by Francis Ginther
Status: Merged
Approved by: Celso Providelo
Approved revision: 29
Merged at revision: 28
Proposed branch: lp:~fginther/core-image-publisher/hardcoded-edge-rolling
Merge into: lp:core-image-publisher
Diff against target: 29 lines (+10/-2)
1 file modified
core_image_publisher/worker.py (+10/-2)
To merge this branch: bzr merge lp:~fginther/core-image-publisher/hardcoded-edge-rolling
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Thomi Richards (community) Approve
Review via email: mp+257175@code.launchpad.net

Commit message

Hardcode core image download to edge and rolling, ignoring the passed in channel.

This also uses a different approach for getting rid of the .gnupg dir owned by root as suggested here:
https://code.launchpad.net/~fginther/core-image-publisher/edge-support/+merge/257165

Description of the change

Hardcode core image download to edge and rolling, ignoring the passed in channel.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM

review: Approve
Revision history for this message
Celso Providelo (cprov) :
review: Approve
29. By Francis Ginther

Remove import getpass as it's not needed anymore.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'core_image_publisher/worker.py'
--- core_image_publisher/worker.py 2015-04-08 20:14:12 +0000
+++ core_image_publisher/worker.py 2015-04-23 01:33:19 +0000
@@ -115,16 +115,24 @@
115 # worker and perform testing retries.115 # worker and perform testing retries.
116 'HOME': tmpdir,116 'HOME': tmpdir,
117 }117 }
118 # The folling uses hardcoded parameters for '--channel' and 'release'.
119 # It is ignoring the channel value passed in.
118 cmd = ['sudo',120 cmd = ['sudo',
119 'ubuntu-device-flash',121 'ubuntu-device-flash',
120 '--revision', name,122 '--revision', name,
121 'core',123 'core',
122 '--device', device,124 '--device', device,
123 '--channel', channel,125 '--channel', 'edge',
124 '--size', '3',126 '--size', '3',
125 '-o', image_path,127 '-o', image_path,
126 '--developer-mode',128 '--developer-mode',
127 '--cloud']129 '--cloud',
130 'rolling']
131 check_call(cmd, env=udf_env)
132 cmd = ['sudo',
133 'rm',
134 '-rf',
135 os.path.join(tmpdir, '.gnupg')]
128 check_call(cmd, env=udf_env)136 check_call(cmd, env=udf_env)
129 return image_path137 return image_path
130138

Subscribers

People subscribed via source and target branches