Juju Charms Collection
jenkins-remote-slave package

Code review comment for lp:~fginther/charms/trusty/jenkins-remote-slave/jenkins-phablet-slave

  1. Trusty Tahr (14.04)
  2. jenkins-phablet-slave
  3. Merge into trunk
Revision history for this message
Francis Ginther (fginther) wrote :

To address the multiple comments on "files/jenkins-slave/jenkins-slave-remote". This file is a copy of the one supplied by the jenkins-slave package. The only values we actually care about are: NAME,
JENKINS_HOSTNAME and JENKINS_URL. An improved sed command would allow us to use the one supplied by the package itself and not have to supply the copy.

files/jenkins-slave/jenkins-slave-remote.conf is also supplied by the jenkins-slave package, but its version is missing the start/stop/respawn portion.

I'll attempt to respond the comments for changes, but may have to iterate with plars on a few. Will make note if this is the case.

« Back to merge proposal