Juju Charms Collection
jenkaas package

Code review comment for lp:~fginther/charms/trusty/jenkaas/configure-slaves

  1. Trusty Tahr (14.04)
  2. configure-slaves
  3. Merge into trunk
Revision history for this message
Para Siva (psivaa) wrote :

Looks good except an inline comment about an unused import.

A little bit curious about if we could not use 'start' callbacks in the first ServiceManager instance for creating the slave. By then the service will have started, i guess.

review: Approve
Reply

« Back to merge proposal