Merge lp:~fginther/charms/trusty/core-image-tester/remove-uci-nova into lp:~canonical-ci-engineering/charms/trusty/core-image-tester/trunk

Proposed by Francis Ginther
Status: Merged
Approved by: Celso Providelo
Approved revision: 6
Merged at revision: 6
Proposed branch: lp:~fginther/charms/trusty/core-image-tester/remove-uci-nova
Merge into: lp:~canonical-ci-engineering/charms/trusty/core-image-tester/trunk
Diff against target: 31 lines (+0/-10)
2 files modified
hooks/actions.py (+0/-9)
hooks/services.py (+0/-1)
To merge this branch: bzr merge lp:~fginther/charms/trusty/core-image-tester/remove-uci-nova
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+257599@code.launchpad.net

Commit message

Remove installation of separate uci-nova ssh setup script.

Description of the change

Remove installation of separate uci-nova ssh setup script.

lp:core-image-tester is already using an inline copy of uci-nova.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Yep. On a slightly unrelated note, are we going to remove uci-nova as a separate project to avoid confusion?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/actions.py'
--- hooks/actions.py 2015-04-09 18:42:14 +0000
+++ hooks/actions.py 2015-04-28 02:11:54 +0000
@@ -47,15 +47,6 @@
47 archive.extract_tarfile(tarball, os.path.dirname(_service_dir()))47 archive.extract_tarfile(tarball, os.path.dirname(_service_dir()))
4848
4949
50def install_adt_uci_nova(service_name):
51 hookenv.log('Attempting to install "uci-nova" autopkgtest ssh-setup ...')
52 uci_nova_path = os.path.join(hookenv.charm_dir(), 'files', 'uci-nova')
53 if not os.path.exists(uci_nova_path):
54 hookenv.log('"uci-nova" not provided, nothing installed!')
55 return
56 shutil.copy2(uci_nova_path, '/usr/share/autopkgtest/ssh-setup/')
57
58
59def update_config_file(service_name):50def update_config_file(service_name):
60 hookenv.log(51 hookenv.log(
61 'Updating service configuration file: %s', SERVICE_CONFIGNAME)52 'Updating service configuration file: %s', SERVICE_CONFIGNAME)
6253
=== modified file 'hooks/services.py'
--- hooks/services.py 2015-04-01 13:44:08 +0000
+++ hooks/services.py 2015-04-28 02:11:54 +0000
@@ -18,7 +18,6 @@
18 actions.install_packages,18 actions.install_packages,
19 actions.install_service_tarball,19 actions.install_service_tarball,
20 actions.install_python_packages,20 actions.install_python_packages,
21 actions.install_adt_uci_nova,
22 actions.update_config_file,21 actions.update_config_file,
23 actions.create_user,22 actions.create_user,
24 helpers.render_template(23 helpers.render_template(

Subscribers

People subscribed via source and target branches