Merge lp:~fgimenez/snappy/hw-assign-test into lp:~snappy-dev/snappy/snappy-moved-to-github

[Federico Gimenez]

hw-assign integration test

hw-assign integration test

[Leo Arias (elopio)]

cool. Left a couple of comments about typos.

review: Needs Fixing

[lp:~fgimenez/snappy/hw-assign-test]

738. By Federico Gimenez on 2015-10-06

Fixed typo and wrong sentence

[Federico Gimenez (fgimenez)]

Thanks Leo, it should be fixed now

[Leo Arias (elopio)]

START: /home/elopio/workspace/go/src/launchpad.net/snappy/_integration-tests/tests/hwAssign_test.go:48: hwAssignSuite.SetUpTest
fatal error: runtime: out of memory

That's because you are calling SetUpTest in SetUpTest.

The right call is:
s.SnappySuite.SetUpTest(c)

The same problem with tear down.

review: Needs Fixing

[lp:~fgimenez/snappy/hw-assign-test]

739. By Federico Gimenez on 2015-10-07

Calling fixtures on SnappySuite

[Federico Gimenez (fgimenez)]

Sorry, it's fixed now.

Thanks!

[Leo Arias (elopio)]

review: Approve

=== added directory '_integration-tests/data/snaps/dev-kmsg'
=== added directory '_integration-tests/data/snaps/dev-kmsg/bin'
=== added file '_integration-tests/data/snaps/dev-kmsg/bin/reader'
--- _integration-tests/data/snaps/dev-kmsg/bin/reader	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/dev-kmsg/bin/reader	2015-10-07 07:39:35 +0000
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+dd if=/dev/kmsg iflag=nonblock
 \ No newline at end of file
 
=== added directory '_integration-tests/data/snaps/dev-kmsg/meta'
=== added file '_integration-tests/data/snaps/dev-kmsg/meta/package.yaml'
--- _integration-tests/data/snaps/dev-kmsg/meta/package.yaml	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/dev-kmsg/meta/package.yaml	2015-10-07 07:39:35 +0000
@@ -0,0 +1,6 @@
+name: dev-kmsg
+version: 1.0
+vendor: Snappy Developers <[e-mail]>
+icon: meta/snappy64.png
+binaries:
+ - name: bin/reader
 
=== added file '_integration-tests/data/snaps/dev-kmsg/meta/readme.md'
--- _integration-tests/data/snaps/dev-kmsg/meta/readme.md	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/dev-kmsg/meta/readme.md	2015-10-07 07:39:35 +0000
@@ -0,0 +1,5 @@
+dev-kmsg snap
+
+This simple snap provides a binary to read and output real raw
+data from /dev/kmsg using dd. For it to work it needs that hw
+to be assigned before being run.
 
=== added file '_integration-tests/data/snaps/dev-kmsg/meta/snappy64.png'
 Binary files _integration-tests/data/snaps/dev-kmsg/meta/snappy64.png	1970-01-01 00:00:00 +0000 and _integration-tests/data/snaps/dev-kmsg/meta/snappy64.png	2015-10-07 07:39:35 +0000 differ
=== added file '_integration-tests/tests/hwAssign_test.go'
--- _integration-tests/tests/hwAssign_test.go	1970-01-01 00:00:00 +0000
+++ _integration-tests/tests/hwAssign_test.go	2015-10-07 07:39:35 +0000
@@ -0,0 +1,106 @@
+// -*- Mode: Go; indent-tabs-mode: t -*-
+
+/*
+ * Copyright (C) 2015 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package tests
+
+import (
+	"fmt"
+	"os"
+	"os/exec"
+
+	"launchpad.net/snappy/_integration-tests/testutils/build"
+	"launchpad.net/snappy/_integration-tests/testutils/common"
+
+	"gopkg.in/check.v1"
+)
+
+const (
+	snapName          = "dev-kmsg"
+	binName           = snapName + ".reader"
+	installedSnapName = snapName + ".sideload"
+	hwName            = "/dev/kmsg"
+	hwAssignError     = "dd: failed to open ‘" + hwName + "’: Permission denied\n"
+)
+
+var _ = check.Suite(&hwAssignSuite{})
+
+type hwAssignSuite struct {
+	common.SnappySuite
+	snapPath string
+}
+
+func (s *hwAssignSuite) SetUpTest(c *check.C) {
+	s.SnappySuite.SetUpTest(c)
+	var err error
+	s.snapPath, err = build.LocalSnap(c, snapName)
+	c.Assert(err, check.IsNil)
+	common.InstallSnap(c, s.snapPath)
+}
+
+func (s *hwAssignSuite) TearDownTest(c *check.C) {
+	s.SnappySuite.TearDownTest(c)
+	os.Remove(s.snapPath)
+	common.RemoveSnap(c, snapName)
+}
+
+func (s *hwAssignSuite) TestErrorWithoutHwAssign(c *check.C) {
+	cmd := exec.Command(binName)
+	output, err := cmd.CombinedOutput()
+
+	c.Assert(err, check.NotNil)
+	c.Assert(string(output), check.Equals, hwAssignError)
+}
+
+func (s *hwAssignSuite) TestSuccessAfterHwAssign(c *check.C) {
+	assign(c, snapName, hwName)
+	defer unassign(c, snapName, hwName)
+
+	cmd := exec.Command(binName)
+	output, _ := cmd.CombinedOutput()
+
+	c.Assert(string(output), check.Not(check.Equals), hwAssignError)
+}
+
+func (s *hwAssignSuite) TestErrorAfterHwUnAssign(c *check.C) {
+	assign(c, snapName, hwName)
+	unassign(c, snapName, hwName)
+
+	cmd := exec.Command(binName)
+	output, err := cmd.CombinedOutput()
+
+	c.Assert(err, check.NotNil)
+	c.Assert(string(output), check.Equals, hwAssignError)
+}
+
+func assign(c *check.C, snap, hw string) {
+	cmd := exec.Command("sudo", "snappy", "hw-assign", installedSnapName, hwName)
+	output, err := cmd.CombinedOutput()
+	c.Assert(err, check.IsNil)
+	c.Assert(string(output), check.Equals,
+		fmt.Sprintf("'%s' is now allowed to access '%s'\n", installedSnapName, hwName))
+}
+
+func unassign(c *check.C, snap, hw string) {
+	cmd := exec.Command("sudo", "snappy", "hw-unassign", installedSnapName, hwName)
+	output, err := cmd.CombinedOutput()
+	c.Assert(err, check.IsNil)
+	c.Assert(string(output), check.Equals,
+		fmt.Sprintf("'%s' is no longer allowed to access '%s'\n", installedSnapName, hwName))
+
+}