Code review comment for lp:~fgimenez/snappy/filter-tests

Revision history for this message
Leo Arias (elopio) wrote :

Shouldn't we have a default control file?
I'm thinking about the future when we can specify the requirements as test classes in the control file, so the runner can call adt-run directly without using our main.go.

So I like this a lot, but I was thinking about also parsing the control file to look for test bed requirements. We can talk tomorrow to figure out how to have both, filtering and test bed specs.

Also, remember that we can't call the test binary directly because the reboot will kill it and we'll lose the results. We need to merge this with the approach in https://code.launchpad.net/~elopio/snappy/upgrade-test/+merge/262657 , that uses a bash script that runs the test binary.

« Back to merge proposal