Code review comment for lp:~fgiff/linaro-android-build-tools/linaro-android-connect-android-build-to-lava

Revision history for this message
Paul Larson (pwlars) wrote :

I agree with what James and Paul pointed out, you don't want the token to be publicly visible to anyone. Maybe you could load it from a config file on the machine or something? Please fix this, and if you already have a token that's visible externally, I would recommend removing it and creating a new onw.

Approving for my part because it looks ok otherwise, but please fix Paul's need-fix before going forward with it.

review: Approve

« Back to merge proposal