Code review comment for lp:~fgiff/linaro-android-build-tools/linaro-android-connect-android-build-to-lava

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

I agree about usage of json module. My idea was also that this script should take values it needs from the environment, not on command line, then it would be more flexible. For example, regarding toggle James talks about - I guess, for starters, we'd want to enable submission feature just for few selected jobs, so the script could check for LAVA_SUBMIT=1 var. Later, we may want to have it enabled by default and have switch to disable it instead. This all can be done in the script itself.

Anyway, current idea is to provide you with a sandbox, where you can test/tweak such integration issues (more info in email).

review: Approve

« Back to merge proposal