Code review comment for lp:~fenryxo/zim/templates-pagemenu

2011/6/6 Jaap Karssenberg <email address hidden>:
> 2011/6/6 Jiří Janoušek <email address hidden>
>
>> > * collapse now mimics the standard index, so it shows all of the toplevel
>> pages and pages in any expanded sub page
>>
>
>
>> If I understand it correctly, collapse works like the original example
>> (e.g. http://tmp.doublej.cz/pagemenu /Help/Export.html ) Or if I'm
>> missing something, can you put somewhere similar example output?
>>
>>
> Yes, for two level depth the behavior is the same. However it now keeps
> showing the top level also for deeper nested pages

My code should keep top level too (unless a different starting
namespace is explicitly given). If not, it's a mistake, not purpose.

>> > * hide_empty now only hides pages that don't have content OR children,
>> this is needed because otherwise namspaces were the parent has no text
>> disappear.
>>
>> The hide_empty option was intended to prevent creating links to
>> non-existing pages. But the proper solution could be to create little
>> index pages listing child nodes (like in WWWInterface).
>>
>
> Maybe we need to check common code between IndexPage and this function.

The menu function is based on IndexPage code, but I think IndexPage
doesn't require extra logic from menu (home page order manipulation,
current page in bold, ...). It should get starting namespace and level
limit to be usable as a page body for empty pages with children.

> -- Jaap
>
> --
> https://code.launchpad.net/~janousek.jiri/zim/templates-pagemenu/+merge/60616
> You are the owner of lp:~janousek.jiri/zim/templates-pagemenu.
>