Code review comment for lp:~feng-kylin/unity8/removeHorizonalRuleOnUnlockScreen

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I don't really like the placeholder Item...

This ends up being this right now:

Column {

  UpperItem { }

  Item {}

  LowerItem {}

Wouldn't it be better to just drop the middle Item and adjust the spacing to (I know that'll cause things to be off by units.dp(2) but I don't think that's a problem as this behaves slightly different for different screen sizes anyways.

So yes, I agree with Feng.

« Back to merge proposal