Code review comment for lp:~feng-kylin/unity8/openPrepopulatedScopeInManageDash

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Ok, after some investigation I think what this fix does it OK. Since the existing code takes the "fake" result from manage dash model results and activates its uri (which is a canned query like scope://... pointing to the respective scope), we would need to special case it in the plugin code *not* to re-do search, but this is impossible since it's the same execution path we hit when e.g. a redo-search action is triggered in a preview (where we want to re-execute the search even if search string is the same). So, +1 for this fix & thanks!

review: Approve

« Back to merge proposal