Merge lp:~feng-kylin/unity8/fix-lp1431566 into lp:unity8
Proposed by
handsome_feng
Status: | Rejected |
---|---|
Rejected by: | Albert Astals Cid |
Proposed branch: | lp:~feng-kylin/unity8/fix-lp1431566 |
Merge into: | lp:unity8 |
Diff against target: |
12 lines (+1/-1) 1 file modified
qml/Panel/Panel.qml (+1/-1) |
To merge this branch: | bzr merge lp:~feng-kylin/unity8/fix-lp1431566 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti | Pending | ||
Unity Team | Pending | ||
Review via email: mp+256466@code.launchpad.net |
Commit message
Make the WindowControlBu
Description of the change
Make the WindowControlBu
To post a comment you must log in.
Unmerged revisions
- 1731. By handsome_feng
-
Make the WindowControlBu
ttons show only under windowed mode
Thanks for the contribution. Unfortunately this is not really how it should be done. "usageModeSettings" is not part of Panel.qml. It is bad practice to reach out of context like this and will cause a mess in the long run.
Also, there are more issues with those buttons and I already have a branch upcoming that improves the situation. I'm very sorry. I should have marked the bug as "in progress".