Merge lp:~mzanetti/unity8/panel-buttons-fixes into lp:unity8

Proposed by Michael Zanetti
Status: Rejected
Rejected by: Michael Zanetti
Proposed branch: lp:~mzanetti/unity8/panel-buttons-fixes
Merge into: lp:unity8
Diff against target: 49 lines (+13/-1)
2 files modified
qml/Shell.qml (+8/-0)
qml/Stages/DesktopStage.qml (+5/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/panel-buttons-fixes
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+256490@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

1711. By Michael Zanetti

some fixes for the panel buttons

1710. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Shell.qml'
2--- qml/Shell.qml 2015-04-09 14:01:00 +0000
3+++ qml/Shell.qml 2015-04-16 13:34:25 +0000
4@@ -37,6 +37,7 @@
5 import "Stages"
6 import "Tutorial"
7 import "Wizard"
8+import "Components/PanelState"
9 import Unity.Notifications 1.0 as NotificationBackend
10 import Unity.Session 0.1
11 import Unity.DashCommunicator 0.1
12@@ -218,6 +219,13 @@
13 }
14 }
15
16+ Binding {
17+ target: PanelState
18+ property: "buttonsVisible"
19+ value: false
20+ when: usageModeSettings.usageMode !== "Windowed"
21+ }
22+
23 Loader {
24 id: applicationsDisplayLoader
25 objectName: "applicationsDisplayLoader"
26
27=== modified file 'qml/Stages/DesktopStage.qml'
28--- qml/Stages/DesktopStage.qml 2015-03-13 19:18:35 +0000
29+++ qml/Stages/DesktopStage.qml 2015-04-16 13:34:25 +0000
30@@ -58,7 +58,7 @@
31 id: priv
32
33 readonly property string focusedAppId: ApplicationManager.focusedApplicationId
34- readonly property var focusedAppDelegate: focusedAppId ? appRepeater.itemAt(indexOf(focusedAppId)) : null
35+ readonly property var focusedAppDelegate: focusedAppId && appRepeater.count == ApplicationManager.count ? appRepeater.itemAt(indexOf(focusedAppId)) : null
36
37 function indexOf(appId) {
38 for (var i = 0; i < ApplicationManager.count; i++) {
39@@ -85,6 +85,10 @@
40 value: priv.focusedAppDelegate !== null && priv.focusedAppDelegate.state === "maximized"
41 }
42
43+ Component.onDestruction: {
44+ PanelState.buttonsVisible = false;
45+ }
46+
47 Repeater {
48 id: appRepeater
49 model: ApplicationManager

Subscribers

People subscribed via source and target branches