Code review comment for lp:~feng-kylin/unity8/fix-lp1413791

Revision history for this message
handsome_feng (feng-kylin) wrote :

> Why did you introduce the resetAll if it's always used when
> dash.setCurrentScope is used? Maybe just do the resetAll code in it?

Because I think long left swipe/BFB may reset something else more than the search string in the future. but I think you are right, the signal is not necessary here, I will modify this.Thank you!

« Back to merge proposal