Code review comment for lp:~feng-kylin/unity8/cantClickOnDashWhileDraggingAnIcon

Revision history for this message
handsome_feng (feng-kylin) wrote :

> Also, turns out that converting the existing MouseArea to a
> MultiPointTouchArea is enough to fix the bug. No need to have a MouseArea and
> a MultiPointTouchArea.

Simply converting the MouseArea to MultiPointTouchArea will lead to a problem that
when running unity8 with argument "-mousetouch", it needs click twice to dismiss
the Launcher. Maybe something wrong between MouseTouchAdaptor and MultiPointTouchArea?
:/

> For the test I think it would make sense to change the drag'n'drop to be
> performed with touch input too. Maybe we could add a _data() function that
> does the test once with touch and once with mouse.

yeah, I have done it.

« Back to merge proposal