Code review comment for lp:~feng-kylin/unity/MoveDashToBottom

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

I can't reproduce that, do you have a proper method?
> However it seems something we can fix in a different branch.

Ok, I've noticed what you mean now... The thing is that the new tooltip is opened before the old one is closed, and thus, there's a double blurred background. Now, this doesn't happen in vertical mode because there's no overlapping area. Since the damage events arrives with some delay, there's glitch.

So, in order to get that working we need to quickly hide the tooltips when in horizontal mode.
This is one way: http://pastebin.ubuntu.com/15391195/

So please apply that diff, although you need to fix tests for that to work (I've just built it for testing purposes).
Also instead of "virtual void HideTooltip(bool prompt = false) = 0" in AbstractLauncherIcon maybe it's better if you add a new "virtual void PromptHideTooltip()" or better.

But this should give you an idea.

« Back to merge proposal