Code review comment for lp:~feng-kylin/unity/ExtendLockscreenTheme

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

I would prefer to call LockScreenAbstractShield as LockScreenBaseShield and moving the implementation in a cpp file.

I can do this kind of work, so I can double-check that both implementations keep the things together.
Let me know if it's fine if I provide a branch that you can merge with this.

« Back to merge proposal