QA Regression Testing

Code review comment for ~federicoquattrin/qa-regression-testing:add_cjson_tests

  1. Git
  2. lp:~federicoquattrin/qa-regression-testing
  3. add_cjson_tests
  4. Merge into master
Revision history for this message
Federico Quattrin (federicoquattrin) wrote (last edit ):

> Hi Federico, thanks for the tests! Two small things here: `vm-qrt` seems to
> need the executable bit set for `test-cjson.py` in order to work properly (and
> you can see all test-*.py have it set). The other one is you might want to add
> `gcc` to `QRT-Packages:` too?
>
> Just my 2 ct, thanks again for the tests!

Hey Allen! Thanks for your feedback! I included your proposal in this commit: https://git.launchpad.net/~federicoquattrin/qa-regression-testing/commit/?id=4c10738d499e90f4e41e5ec6d7de353d78427170.

Thanks!

Reply

« Back to merge proposal