Merge lp:~fboucault/unity-2d/fix_dash_crash_817896 into lp:unity-2d/3.0

Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 659
Merged at revision: 659
Proposed branch: lp:~fboucault/unity-2d/fix_dash_crash_817896
Merge into: lp:unity-2d/3.0
Diff against target: 24 lines (+13/-1)
1 file modified
places/dash.qml (+13/-1)
To merge this branch: bzr merge lp:~fboucault/unity-2d/fix_dash_crash_817896
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+70131@code.launchpad.net

Description of the change

[dash] Fixed crash when closing dash due to Qt bug https://bugreports.qt.nokia.com/browse/QTBUG-20692

To post a comment you must log in.
Revision history for this message
Bob The Builder (bobthebuilder-deactivatedaccount) wrote :

No approved revision specified.

Revision history for this message
Gerry Boland (gerboland) wrote :

Nice find!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'places/dash.qml'
--- places/dash.qml 2011-07-27 19:02:12 +0000
+++ places/dash.qml 2011-08-02 10:39:45 +0000
@@ -33,7 +33,19 @@
33 /* Unload the current page when closing the dash */33 /* Unload the current page when closing the dash */
34 Connections {34 Connections {
35 target: dashView35 target: dashView
36 onActiveChanged: if (!dashView.active) pageLoader.source = ""36 onActiveChanged: {
37 if (!dashView.active) {
38 /* FIXME: currentPage needs to stop pointing to pageLoader.item
39 that is about to be invalidated otherwise a crash
40 occurs because SearchEntry has a binding that refers
41 to currentPage and tries to access it.
42 Ref.: https://bugs.launchpad.net/ubuntu/+source/unity-2d/+bug/817896
43 https://bugreports.qt.nokia.com/browse/QTBUG-20692
44 */
45 currentPage = undefined
46 pageLoader.source = ""
47 }
48 }
37 }49 }
3850
39 function activatePage(page) {51 function activatePage(page) {

Subscribers

People subscribed via source and target branches