Code review comment for lp:~fboucault/unity-2d/cache_dash_background

Revision history for this message
Florian Boucault (fboucault) wrote :

Looking at the screenshots, I don't think this patch makes the situation worse: the dash is not transparent in either case. Before the patch its background is plain white, after the patch its background is plain black. I would merge it for the performance improvement and try to fix the transparency issue separately.
I don't have a working device on which I can try various possible fixes with an OpenGL/ES driver. Could you try one thing and see if the transparency works better?

in libunity-2d-private/src/unity2ddeclarativeview.cpp line 61, change:

            setAttribute(Qt::WA_OpaquePaintEvent, true);

into:
            setAttribute(Qt::WA_OpaquePaintEvent, false);

If that does not help, try to add the following line just after:

            glWidget->setAutoFillBackground(true);

« Back to merge proposal