Code review comment for lp:~fboucault/ubuntu-ui-toolkit/ubuntu_colors

Revision history for this message
Florian Boucault (fboucault) wrote :

> > UbuntuColors is in the module Ubuntu.Components, which already has Ubuntu in
> > the name so instead of Ubuntu.Components.UbuntuColors we could rename the
> > colors to Ubuntu.Components.Colors.
>
> As a developer you wouldn't readily associate in your mind the Colors object
> with the Ubuntu color palette, hence the name. The import name is quite
> distant code wise (as a developer you put it at the beginning of the file and
> forget it) and does not really help making the connection.

A similar reasoning was used for UbuntuAnimation.

« Back to merge proposal