Code review comment for lp:~fboucault/ubuntu-ui-toolkit/ubuntu_colors

Revision history for this message
Florian Boucault (fboucault) wrote :

> 394 public:
> 395 void registerTypes(const char *uri);
> 396 void initializeEngine(QQmlEngine *engine, const char *uri);
> 397 + QUrl baseUrl(QStringList importPathList, const char* uri);
> 398 + void registerQmlSingletonType(QQmlEngine *engine, const char* uri,
> const char* typeName, const char* qmlFile);
>
> Do they have to be public?

Nobody can nor will instantiate the plugin manually so it does not really matter :)

« Back to merge proposal