Code review comment for lp:~fboucault/ubuntu-ui-toolkit/support_quotes_in_sci

Revision history for this message
Florian Boucault (fboucault) wrote :

> Looks fine, and maintains backward compatibility. Though I question if we
> should be more strict and poke people to update their .sci files?
>
> One question: why escape the double quote character to get the char? I
> expected '"' to just work.

Better safe than sorry was the reasoning but you are right, removed escaping.

« Back to merge proposal