Merge lp:~fboucault/ubuntu-ui-toolkit/list_item_single_control_min_height into lp:ubuntu-ui-toolkit
Proposed by
Florian Boucault
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Florian Boucault | ||||
Approved revision: | 589 | ||||
Merged at revision: | 589 | ||||
Proposed branch: | lp:~fboucault/ubuntu-ui-toolkit/list_item_single_control_min_height | ||||
Merge into: | lp:ubuntu-ui-toolkit | ||||
Diff against target: |
13 lines (+3/-0) 1 file modified
modules/Ubuntu/Components/ListItems/SingleControl.qml (+3/-0) |
||||
To merge this branch: | bzr merge lp:~fboucault/ubuntu-ui-toolkit/list_item_single_control_min_height | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Sebastien Bacher (community) | Approve | ||
Ubuntu SDK team | Pending | ||
Review via email: mp+173214@code.launchpad.net |
Commit message
ListItem.
To post a comment you must log in.
Looks good to me, note that it doesn't fix the specific issue I reported because I use Base to workaround the margin problem described in https:/ /bugs.launchpad .net/ubuntu- ui-toolkit/ +bug/1194844 (buttons should start/end at the same horizontal position as the labels from standard items)