Merge lp:~fboucault/ubuntu-calculator-app/new_theming into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Florian Boucault
Status: Merged
Approved by: Dalius
Approved revision: 91
Merged at revision: 90
Proposed branch: lp:~fboucault/ubuntu-calculator-app/new_theming
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 48 lines (+11/-2)
2 files modified
Simple/CalcLabel.qml (+6/-1)
Simple/Screen.qml (+5/-1)
To merge this branch: bzr merge lp:~fboucault/ubuntu-calculator-app/new_theming
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Dalius (community) Approve
Review via email: mp+171888@code.launchpad.net

Commit message

Adapted to newer and simpler toolkit's theming infrastructure.

The ItemStyle attached property has been removed and widgets now have a 'style' property equivalent to what ItemStyle.delegate was providing.
The Ubuntu UI Toolkit merge request containing that change is: https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/simple_theming/+merge/171645
It will be merged in the morning so that the fixes for this app can be merged in the same day.

For testing, armhf packages of the toolkit are available at: http://people.canonical.com/~kaleo/sdk_simple_theming/

To post a comment you must log in.
Revision history for this message
Dalius (dalius-sandbox) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Simple/CalcLabel.qml'
--- Simple/CalcLabel.qml 2013-06-14 16:57:35 +0000
+++ Simple/CalcLabel.qml 2013-06-27 19:04:27 +0000
@@ -18,6 +18,7 @@
1818
19import QtQuick 2.019import QtQuick 2.0
20import Ubuntu.Components 0.120import Ubuntu.Components 0.1
21import Ubuntu.Components.Themes.Ambiance 0.1
2122
22Item {23Item {
23 id: root24 id: root
@@ -69,7 +70,11 @@
69 id: numberName70 id: numberName
70 width: parent.width71 width: parent.width
71 anchors.verticalCenter: parent.verticalCenter72 anchors.verticalCenter: parent.verticalCenter
72 ItemStyle.delegate: Item{} // removes ubuntu shape73 // removes ubuntu shape
74 style: TextFieldStyle {
75 background: Item {}
76 }
77
73 readOnly: labelReadOnly78 readOnly: labelReadOnly
74 text: labelText79 text: labelText
75 color: "#FEFEFE"80 color: "#FEFEFE"
7681
=== modified file 'Simple/Screen.qml'
--- Simple/Screen.qml 2013-06-14 16:19:05 +0000
+++ Simple/Screen.qml 2013-06-27 19:04:27 +0000
@@ -18,6 +18,7 @@
1818
19import QtQuick 2.019import QtQuick 2.0
20import Ubuntu.Components 0.120import Ubuntu.Components 0.1
21import Ubuntu.Components.Themes.Ambiance 0.1
21import Ubuntu.Components.ListItems 0.122import Ubuntu.Components.ListItems 0.1
2223
23//TODO: reuse a number clicking on it24//TODO: reuse a number clicking on it
@@ -128,7 +129,10 @@
128129
129 TextField{130 TextField{
130 width: parent.width131 width: parent.width
131 ItemStyle.delegate: Item{} // removes ubuntu shape132 // removes ubuntu shape
133 style: TextFieldStyle {
134 background: Item {}
135 }
132 text: mainLabel136 text: mainLabel
133 hasClearButton: false137 hasClearButton: false
134 color: "#FEFEFE"138 color: "#FEFEFE"

Subscribers

People subscribed via source and target branches