Code review comment for lp:~fboucault/thumbnailer/new_qml_api

> I didn't get to review the functional bits quite yet, but here are some
> simpler issues in the mean time.
>
> - the qml tests don't seem to be run
> - the bit that converts relative file names to absolute ones is duplicated in
> get_thumbnail and needs_generation, please move it to a shared function in an
> anonymous namespace

Fixed.

> - the name needs_generation seems a bit backwards, would it be better to call
> it is_cached instead

Fixed.