Merge lp:~fboucault/camera-app/video_thumbnails into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 351
Merged at revision: 354
Proposed branch: lp:~fboucault/camera-app/video_thumbnails
Merge into: lp:camera-app
Diff against target: 43 lines (+8/-0)
2 files modified
CameraApp/foldersmodel.cpp (+7/-0)
CameraApp/foldersmodel.h (+1/-0)
To merge this branch: bzr merge lp:~fboucault/camera-app/video_thumbnails
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+230361@code.launchpad.net

Commit message

Ensure video thumbnails are generated as soon as possible by monitoring changes to files themselves.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Everything seems to be ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CameraApp/foldersmodel.cpp'
--- CameraApp/foldersmodel.cpp 2014-07-31 19:03:14 +0000
+++ CameraApp/foldersmodel.cpp 2014-08-11 17:43:28 +0000
@@ -25,6 +25,7 @@
25{25{
26 m_watcher = new QFileSystemWatcher(this);26 m_watcher = new QFileSystemWatcher(this);
27 connect(m_watcher, SIGNAL(directoryChanged(QString)), this, SLOT(directoryChanged(QString)));27 connect(m_watcher, SIGNAL(directoryChanged(QString)), this, SLOT(directoryChanged(QString)));
28 connect(m_watcher, SIGNAL(fileChanged(QString)), this, SLOT(fileChanged(QString)));
28}29}
2930
30QStringList FoldersModel::folders() const31QStringList FoldersModel::folders() const
@@ -83,6 +84,7 @@
83 QFileInfoList fileInfoList = currentDir.entryInfoList(QDir::Files | QDir::Readable,84 QFileInfoList fileInfoList = currentDir.entryInfoList(QDir::Files | QDir::Readable,
84 QDir::Time | QDir::Reversed);85 QDir::Time | QDir::Reversed);
85 Q_FOREACH (QFileInfo fileInfo, fileInfoList) {86 Q_FOREACH (QFileInfo fileInfo, fileInfoList) {
87 m_watcher->addPath(fileInfo.absoluteFilePath());
86 QString type = m_mimeDatabase.mimeTypeForFile(fileInfo).name();88 QString type = m_mimeDatabase.mimeTypeForFile(fileInfo).name();
87 Q_FOREACH (QString filterType, m_typeFilters) {89 Q_FOREACH (QString filterType, m_typeFilters) {
88 if (type.startsWith(filterType)) {90 if (type.startsWith(filterType)) {
@@ -178,6 +180,11 @@
178 updateFileInfoList();180 updateFileInfoList();
179}181}
180182
183void FoldersModel::fileChanged(const QString &filePath)
184{
185 updateFileInfoList();
186}
187
181void FoldersModel::toggleSelected(int row)188void FoldersModel::toggleSelected(int row)
182{189{
183 if (m_selectedFiles.contains(row)) {190 if (m_selectedFiles.contains(row)) {
184191
=== modified file 'CameraApp/foldersmodel.h'
--- CameraApp/foldersmodel.h 2014-07-31 19:03:14 +0000
+++ CameraApp/foldersmodel.h 2014-08-11 17:43:28 +0000
@@ -63,6 +63,7 @@
6363
64public Q_SLOTS:64public Q_SLOTS:
65 void directoryChanged(const QString &directoryPath);65 void directoryChanged(const QString &directoryPath);
66 void fileChanged(const QString &directoryPath);
6667
67Q_SIGNALS:68Q_SIGNALS:
68 void foldersChanged();69 void foldersChanged();

Subscribers

People subscribed via source and target branches