Code review comment for lp:~fboucault/camera-app/timer_disable_camera
Revision history for this message
| Florian Boucault (fboucault) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> I have to swipe twice while the timer is running to reach the photo roll. The
> first swipe stops the counter, the second moves to the photo roll. This sounds
> confusing to me and I am not sure if it is what you intended.
>
It is. We don't have (yet) a cancellation button for the timer.
> You added an AP test for timed shooting, which is good, but you did not add a
> test for the feature in this MR.
I did add tests for most of the features in this MR (disabling the various) controls. Not being able to swipe is not tested indeed.