Merge lp:~fboucault/camera-app/test_picture_quality_robust into lp:camera-app/staging

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 666
Merged at revision: 668
Proposed branch: lp:~fboucault/camera-app/test_picture_quality_robust
Merge into: lp:camera-app/staging
Diff against target: 20 lines (+2/-1)
1 file modified
tests/autopilot/camera_app/tests/test_capture.py (+2/-1)
To merge this branch: bzr merge lp:~fboucault/camera-app/test_picture_quality_robust
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+289108@code.launchpad.net

Commit message

Make test_capture.TestCapture.test_picture_quality_setting robust by selecting only pictures.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Look good and tests are ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/camera_app/tests/test_capture.py'
--- tests/autopilot/camera_app/tests/test_capture.py 2016-03-07 14:50:18 +0000
+++ tests/autopilot/camera_app/tests/test_capture.py 2016-03-15 20:50:39 +0000
@@ -17,6 +17,7 @@
17import unittest17import unittest
18import time18import time
19import os19import os
20import glob
2021
2122
22class TestCapture(CameraAppTestCase):23class TestCapture(CameraAppTestCase):
@@ -264,7 +265,7 @@
264 def get_first_picture(self, timeout=10):265 def get_first_picture(self, timeout=10):
265 pictures = []266 pictures = []
266 for i in range(0, timeout):267 for i in range(0, timeout):
267 pictures = os.listdir(self.pictures_dir)268 pictures = glob.glob(os.path.join(self.pictures_dir, "*.jpg"))
268 if len(pictures) != 0:269 if len(pictures) != 0:
269 break270 break
270 time.sleep(1)271 time.sleep(1)

Subscribers

People subscribed via source and target branches