Merge lp:~fboucault/camera-app/test_picture_quality_robust into lp:camera-app/staging

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 666
Merged at revision: 668
Proposed branch: lp:~fboucault/camera-app/test_picture_quality_robust
Merge into: lp:camera-app/staging
Diff against target: 20 lines (+2/-1)
1 file modified
tests/autopilot/camera_app/tests/test_capture.py (+2/-1)
To merge this branch: bzr merge lp:~fboucault/camera-app/test_picture_quality_robust
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+289108@code.launchpad.net

Commit message

Make test_capture.TestCapture.test_picture_quality_setting robust by selecting only pictures.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Look good and tests are ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/camera_app/tests/test_capture.py'
2--- tests/autopilot/camera_app/tests/test_capture.py 2016-03-07 14:50:18 +0000
3+++ tests/autopilot/camera_app/tests/test_capture.py 2016-03-15 20:50:39 +0000
4@@ -17,6 +17,7 @@
5 import unittest
6 import time
7 import os
8+import glob
9
10
11 class TestCapture(CameraAppTestCase):
12@@ -264,7 +265,7 @@
13 def get_first_picture(self, timeout=10):
14 pictures = []
15 for i in range(0, timeout):
16- pictures = os.listdir(self.pictures_dir)
17+ pictures = glob.glob(os.path.join(self.pictures_dir, "*.jpg"))
18 if len(pictures) != 0:
19 break
20 time.sleep(1)

Subscribers

People subscribed via source and target branches