Merge lp:~fboucault/camera-app/state_save_viewfinder into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 325
Merged at revision: 327
Proposed branch: lp:~fboucault/camera-app/state_save_viewfinder
Merge into: lp:camera-app
Diff against target: 72 lines (+9/-2)
3 files modified
ViewFinderOverlay.qml (+4/-1)
ViewFinderView.qml (+4/-1)
camera-app.qml (+1/-0)
To merge this branch: bzr merge lp:~fboucault/camera-app/state_save_viewfinder
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Pending
Review via email: mp+228482@code.launchpad.net

Commit message

Save state of viewfinder: preserve back/front mode, picture/video mode, flash, HDR and location settings.

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :
Revision history for this message
Florian Boucault (fboucault) wrote :

State saving of enum fails, fix is about to be ready. I will link here since this MR will depend on it.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

> State saving of enum fails, fix is about to be ready. I will link here since
> this MR will depend on it.

https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/state_saving_store_type/+merge/228503

Revision history for this message
Florian Boucault (fboucault) wrote :

Both depending MRs have been happroved.

Revision history for this message
Ugo Riboni (uriboni) wrote :

Works as expected (except for known bugs) and code looks ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ViewFinderOverlay.qml'
--- ViewFinderOverlay.qml 2014-07-17 13:39:48 +0000
+++ ViewFinderOverlay.qml 2014-07-28 12:59:27 +0000
@@ -16,7 +16,7 @@
1616
17import QtQuick 2.217import QtQuick 2.2
18import QtQuick.Window 2.018import QtQuick.Window 2.0
19import Ubuntu.Components 1.019import Ubuntu.Components 1.1
20import QtMultimedia 5.020import QtMultimedia 5.0
21import QtPositioning 5.221import QtPositioning 5.2
22import CameraApp 0.122import CameraApp 0.1
@@ -41,6 +41,8 @@
41 property bool gpsEnabled: false41 property bool gpsEnabled: false
42 property bool hdrEnabled: false42 property bool hdrEnabled: false
43 property int videoFlashMode: Camera.FlashOff43 property int videoFlashMode: Camera.FlashOff
44
45 StateSaver.properties: "flashMode, gpsEnabled, hdrEnabled, videoFlashMode"
44 }46 }
4547
46 Binding {48 Binding {
@@ -413,6 +415,7 @@
413 bottomMargin: units.gu(6)415 bottomMargin: units.gu(6)
414 }416 }
415417
418 enabled: !camera.switchInProgress
416 iconName: "camera-flip"419 iconName: "camera-flip"
417 onClicked: controls.switchCamera()420 onClicked: controls.switchCamera()
418 }421 }
419422
=== modified file 'ViewFinderView.qml'
--- ViewFinderView.qml 2014-07-03 08:49:49 +0000
+++ ViewFinderView.qml 2014-07-28 12:59:27 +0000
@@ -16,7 +16,7 @@
1616
17import QtQuick 2.217import QtQuick 2.2
18import QtQuick.Window 2.018import QtQuick.Window 2.0
19import Ubuntu.Components 1.019import Ubuntu.Components 1.1
20import QtMultimedia 5.020import QtMultimedia 5.0
21import CameraApp 0.121import CameraApp 0.1
22import QtGraphicalEffects 1.022import QtGraphicalEffects 1.0
@@ -34,6 +34,7 @@
34 Camera {34 Camera {
35 id: camera35 id: camera
36 captureMode: Camera.CaptureStillImage36 captureMode: Camera.CaptureStillImage
37 StateSaver.properties: "captureMode"
3738
38 function manualFocus(x, y) {39 function manualFocus(x, y) {
39 viewFinderOverlay.showFocusRing(x, y);40 viewFinderOverlay.showFocusRing(x, y);
@@ -59,7 +60,9 @@
59 }60 }
6061
61 property AdvancedCameraSettings advanced: AdvancedCameraSettings {62 property AdvancedCameraSettings advanced: AdvancedCameraSettings {
63 id: advancedCamera
62 camera: camera64 camera: camera
65 StateSaver.properties: "activeCameraIndex"
63 }66 }
6467
65 Component.onCompleted: {68 Component.onCompleted: {
6669
=== modified file 'camera-app.qml'
--- camera-app.qml 2014-07-03 10:18:06 +0000
+++ camera-app.qml 2014-07-28 12:59:27 +0000
@@ -137,6 +137,7 @@
137 }137 }
138138
139 Row {139 Row {
140 id: viewsRow
140 anchors {141 anchors {
141 top: parent.top142 top: parent.top
142 bottom: parent.bottom143 bottom: parent.bottom

Subscribers

People subscribed via source and target branches