Code review comment for lp:~fboucault/camera-app/hook_up_hdr

Code changes look good to me, I haven’t tested them functionally though, as packages for qtubuntu-camera failed to build in silo 12.

One minor question:

10 +// Definition of this enum value is duplicated in qtubuntu-camera
11 +static const QCameraExposure::ExposureMode ExposureHdr = static_cast<QCameraExposure::ExposureMode>(QCameraExposure::ExposureModeVendor + 1);

Couldn’t we patch QtMultimedia to add this value to the QCameraExposure::ExposureMode enum? Or, if this doesn’t make sense, doesn’t qtubuntu-camera expose public headers that we could refer to instead of duplicating the definition of this custom value (which eventually will bite us when they get out of sync)?