Merge lp:~fboucault/camera-app/gps_work_with_no_altitude into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Arthur Mello
Approved revision: 438
Merged at revision: 439
Proposed branch: lp:~fboucault/camera-app/gps_work_with_no_altitude
Merge into: lp:camera-app
Diff against target: 21 lines (+4/-3)
1 file modified
ViewFinderOverlay.qml (+4/-3)
To merge this branch: bzr merge lp:~fboucault/camera-app/gps_work_with_no_altitude
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
Review via email: mp+244113@code.launchpad.net

Commit message

Store location even if no valid altitude was provided.

To post a comment you must log in.
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ViewFinderOverlay.qml'
--- ViewFinderOverlay.qml 2014-12-05 18:43:54 +0000
+++ ViewFinderOverlay.qml 2014-12-09 11:23:34 +0000
@@ -405,13 +405,14 @@
405 var position = positionSource.position;405 var position = positionSource.position;
406 if (settings.gpsEnabled && positionSource.valid406 if (settings.gpsEnabled && positionSource.valid
407 && position.latitudeValid407 && position.latitudeValid
408 && position.longitudeValid408 && position.longitudeValid) {
409 && position.altitudeValid) {
410 camera.imageCapture.setMetadata("GPSLatitude", position.coordinate.latitude);409 camera.imageCapture.setMetadata("GPSLatitude", position.coordinate.latitude);
411 camera.imageCapture.setMetadata("GPSLongitude", position.coordinate.longitude);410 camera.imageCapture.setMetadata("GPSLongitude", position.coordinate.longitude);
412 camera.imageCapture.setMetadata("GPSAltitude", position.coordinate.altitude);
413 camera.imageCapture.setMetadata("GPSTimeStamp", position.timestamp);411 camera.imageCapture.setMetadata("GPSTimeStamp", position.timestamp);
414 camera.imageCapture.setMetadata("GPSProcessingMethod", "GPS");412 camera.imageCapture.setMetadata("GPSProcessingMethod", "GPS");
413 if (position.altitudeValid) {
414 camera.imageCapture.setMetadata("GPSAltitude", position.coordinate.altitude);
415 }
415 }416 }
416 if (main.contentExportMode) {417 if (main.contentExportMode) {
417 camera.imageCapture.captureToLocation(application.temporaryLocation);418 camera.imageCapture.captureToLocation(application.temporaryLocation);

Subscribers

People subscribed via source and target branches