Merge lp:~fboucault/camera-app/export_cancel_button into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 369
Merged at revision: 378
Proposed branch: lp:~fboucault/camera-app/export_cancel_button
Merge into: lp:camera-app
Diff against target: 26 lines (+16/-0)
1 file modified
ViewFinderOverlay.qml (+16/-0)
To merge this branch: bzr merge lp:~fboucault/camera-app/export_cancel_button
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Bill Filler (community) Approve
Review via email: mp+233223@code.launchpad.net

Commit message

Added cancel button in content export mode.

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

works, note that the back button disappears when switching back/front cameras but this is due to another bug tracked here: https://bugs.launchpad.net/barajas/+bug/1362645

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ViewFinderOverlay.qml'
--- ViewFinderOverlay.qml 2014-08-27 00:06:32 +0000
+++ ViewFinderOverlay.qml 2014-09-03 14:09:28 +0000
@@ -498,6 +498,22 @@
498 FocusRing {498 FocusRing {
499 id: focusRing499 id: focusRing
500 }500 }
501
502 CircleButton {
503 id: exportBackButton
504 objectName: "exportBackButton"
505
506 anchors {
507 top: parent.top
508 topMargin: units.gu(4)
509 left: recordModeButton.left
510 }
511
512 iconName: visible ? "go-previous" : ""
513 visible: main.contentExportMode
514 enabled: main.contentExportMode
515 onClicked: main.cancelExport()
516 }
501 }517 }
502518
503 Loader {519 Loader {

Subscribers

People subscribed via source and target branches